feat: add RawAesKeyring for bring-your-own-key encryption - #202
Open
pchikoian wants to merge 1 commit into
Open
Conversation
Adds a keyring that wraps data keys locally with a caller-supplied AES key (16/24/32 bytes) using AES-GCM, with no dependency on AWS KMS. Uses the "AES/GCM" wrapping-algorithm identifier already reserved for this purpose in the object metadata format (V3 code "02"). Also fixes PutEncryptedObjectPipeline and MultipartUploadPipeline, which hardcoded the stored wrapping-algorithm metadata to "kms+context"/"12" regardless of which keyring produced the data key. This silently discarded non-KMS keyrings' wrap-algorithm identifiers and prevented any custom keyring from round-tripping through put_object/get_object. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RawAesKeyring, a keyring that wraps data keys locally with a caller-supplied AES key (16/24/32 bytes) using AES-GCM, with no dependency on AWS KMS. Uses theAES/GCMwrapping-algorithm identifier already reserved for this purpose in the object metadata format (V3 code"02").PutEncryptedObjectPipelineandMultipartUploadPipeline, which hardcoded the stored wrapping-algorithm metadata to"kms+context"/"12"regardless of which keyring produced the data key. This silently discarded non-KMS keyrings' wrap-algorithm identifiers and prevented any custom keyring (including this new one) from round-tripping throughput_object/get_object.Test plan
test/test_raw_aes_keyring.pycovering init validation, encrypt/decrypt round-trip, wrong wrapping key, mismatched key name, mismatched encryption context, tampered ciphertext (23 tests)PutEncryptedObjectPipeline/GetEncryptedObjectPipelinefor both the default V3 (key-committing) and V2 algorithm suitesruff check/ruff format --checkclean🤖 Generated with Claude Code